Skip to content

Conversation

obenland
Copy link
Member

Proposed changes:

  • Refines warning detection and improves robustness of the annotation extraction.
  • Adds logic to track processed file:line combinations and avoid generating duplicate checkstyle annotations for the same @covers warning in the GitHub Actions PHPUnit workflow.

Extracted from #2215.

Adds logic to track processed file:line combinations and avoid generating duplicate checkstyle annotations for the same @Covers warning in the GitHub Actions PHPUnit workflow. Also refines warning detection and improves robustness of the annotation extraction.
@obenland obenland requested a review from pfefferle September 22, 2025 15:56
@obenland obenland self-assigned this Sep 22, 2025
@Copilot Copilot AI review requested due to automatic review settings September 22, 2025 15:56
@obenland obenland added the Skip Changelog Disables the "Changelog Updated" action for PRs where changelog entries are not necessary. label Sep 22, 2025
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR prevents duplicate checkstyle annotations in the PHPUnit workflow by refining warning detection and adding deduplication logic. It addresses cases where the same @covers warning could generate multiple annotations for the same file:line combination.

Key changes:

  • Refines regex patterns for warning detection to improve accuracy
  • Adds tracking of processed file:line combinations using an associative array
  • Implements deduplication logic to skip already-processed annotations

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@obenland obenland merged commit dbf0d11 into trunk Sep 22, 2025
14 checks passed
@obenland obenland deleted the fix/coverage-report branch September 22, 2025 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Actions Skip Changelog Disables the "Changelog Updated" action for PRs where changelog entries are not necessary.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants